Last edited on 15 November 2016 - 11:14 AM by Saevar2000
The mod partially fixes the bug, it prevents lava/water from appearing in two places at once.It does not fix the actual placement coordinates and there's a bit of a delay(not real delay) when you can actually see the lava/water, I'll try to fix that later.
It took a lot of time to make the mod even though it's not a lot of code so leave a "thanks" and tell me if it works :)
The mod was made for Forge-10.13.4.1614-1.7.10.
Download v1.0: https://mega.nz/#!UJIxXSyI!mv-9hufZcVJV666wIaGbVWI4I1CUPnNS_tOSOLkOuAM
Edit: I have fixed the placement coordinates(runs at 120hz now instead of 20hz), will upload tomorrow.
Edit2: Ok, I did not manage to get the face(what side on the block you're placing it on) to run at 120hz but that doesn't really affect anyone. x, y and z now run at 120hz
Edit3: The packet I'm sending to the correct coordinates still changes to the wrong coordinates for some reason, I need to fix that.
Download v1.1: https://mega.nz/#!VcYGmKZS!mmnhVBDrIr9tpgXSmM8ytykOnA8sq3RmE-0DjVnbq0s
Posted on 05 November 2016 - 11:27 PM
Is it allowed? If so thanks for making it! Even if it's not thanks for taking time to try. :)Posted on 05 November 2016 - 11:50 PM
nanotech11 wrote
I see no reason why it shouldn't be allowed @freekkiller
Posted on 06 November 2016 - 02:32 AM
THANKSPosted on 06 November 2016 - 08:32 AM
Source code? Not cause I think it's something bad just I wanna see how it's madeLast edited on 06 November 2016 - 08:46 AM by Saevar2000
ThatOneCombo wrote
That's basically it https://i.imgur.com//MOndsvp.png
Maybe I should put it on github so other people can help make it better/look at the code?
Last edited on 07 November 2016 - 11:48 AM by Archybot
-Archy snip-Posted on 06 November 2016 - 10:05 AM
It fixed the glitch but as you said the buckets are delayed.When I right click a water bucket will it still register and extinguish me immediately or will it take like .5 seconds for it to show up and then extinguish me
Posted on 06 November 2016 - 06:32 PM
ThatOneCombo wrote
When I right click a water bucket will it still register and extinguish me immediately or will it take like .5 seconds for it to show up and then extinguish me
Posted on 06 November 2016 - 08:43 PM
@Saevar2000 slight bucket delay and sometimes lava won't placeLast edited on 06 November 2016 - 09:03 PM by ThatOneCombo
Jarecl wrote
he literally said that in his first paragraph
Posted on 06 November 2016 - 10:17 PM
ThatOneCombo wrote
Jarecl wrote...
he literally said that in his first paragraph
Last edited on 07 November 2016 - 05:55 AM by Saevar2000
I took a look at the delay problem and figured out that it is caused by the latency between you and the server, the delay gives you no real disadvantage because nothing is "really" delayed more than it is without the mod which means that you can use water/lava just as fast.Even though the lava/water isn't on your screen immediately after using it, you can still take the water/lava back into the bucket by clicking the "air" where you placed it.
The mod actually gives you an unfair advantage since you don't get slowed down by water/lava immediately.
I can't think of any easy way to fix this so if anyone would like to help -> https://github.com/Saevar2000/Minecraft-BucketFix
Last edited on 07 November 2016 - 08:15 AM by *deleted-191881
Automatically DeletedPosted on 07 November 2016 - 08:18 AM
Automatically DeletedPosted on 07 November 2016 - 11:24 AM
EhhThing wrote
This could be detected by GCheat because you could have moved and the angles wouldn't sync up.
*facepalm*
EhhThing wrote
It would definitely fix the problem.
That's not sufficient because the lava/water gets placed on incorrect coordinates.
There is no easy way I see to not rendering the double lava/water.
Last edited on 07 November 2016 - 11:49 AM by Archybot
Your if logic has redundant steps (you check for not null twice). Try (item not null) AND (lava OR water) instead of (item not null AND lava) OR (item not null AND water).Also, I will not approve this mod because at first glance. It messes with packets which is a big no no, because if that packet is being sent in non-vanilla fashion it has a chance of flagging gcheat depending on how messed up it is.
Posted on 07 November 2016 - 11:49 AM
@freekkiller will have to test it with me sometime to confirm it doesn't flagPosted on 07 November 2016 - 11:50 AM
Automatically DeletedLast edited on 07 November 2016 - 02:39 PM by Saevar2000
EhhThing wrote
1- Explain.
2- why not just render it at the coordinates that it was placed? You have the coordinates (you get the coordinates that it was supposed to be placed)
1. When placing a block, you always get the right coordinates but with buckets you occasionally send the wrong coordinates when moving very fast from one block to another. There's no reason that placing it at the right coordinates (where you are looking at) would flag GCheat. However like Archy said if the packet is different than the vanilla one it might trigger GCheat.
2. No easy way to do that (that I know of). If you know how to do it just make a pull request.
Archybot wrote
Thanks, I have fixed that :)
Archybot wrote
Also, I will not approve this mod because at first glance. It messes with packets which is a big no no, because if that packet is being sent in non-vanilla fashion it has a chance of flagging gcheat depending on how messed up it is.
I'm fairly sure the packet is just like the vanilla one.